Skip to content

📝 replace all instances of Web3 with w3 #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

wiseaidev
Copy link
Contributor

@wiseaidev wiseaidev commented Feb 22, 2022

Signed-off-by: Harmouch101 [email protected]

What was wrong?

Related to Issue #1183

How was it fixed?

Using the power of vs code IntelliSense along with the search and replace(case sensitive) feature to replace each web3 instance variable name with w3 to avoid confusion with the name of the web3 module.

Todo:

Cute Animal Picture

🦮

@wiseaidev
Copy link
Contributor Author

Good lord, it passes. I feel pain. Awaiting reviews from @pipermerriam, @kclowes, @fselmo...

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits here that I can take care of too. I'm going to pull in the branch in a bit and do a quick search to see if we missed anything but this PR is looking good. Thanks for taking the time! Really appreciate it. 😅

fselmo added a commit to wiseaidev/web3.py that referenced this pull request Feb 23, 2022
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harmouch101 thank you for doing all this, and thanks @fselmo for the review. I looked through too, and it looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants