-
Notifications
You must be signed in to change notification settings - Fork 1.8k
📝 replace all instances of Web3 with w3 #2357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
80ffd35
to
f2672eb
Compare
Good lord, it passes. I feel pain. Awaiting reviews from @pipermerriam, @kclowes, @fselmo... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nits here that I can take care of too. I'm going to pull in the branch in a bit and do a quick search to see if we missed anything but this PR is looking good. Thanks for taking the time! Really appreciate it. 😅
tests/core/filtering/test_contract_createFilter_topic_merging.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harmouch101 thank you for doing all this, and thanks @fselmo for the review. I looked through too, and it looks good to me!
Signed-off-by: Harmouch101 [email protected]
What was wrong?
Related to Issue #1183
How was it fixed?
Using the power of
vs code
IntelliSense along with the search and replace(case sensitive) feature to replace eachweb3
instance variable name withw3
to avoid confusion with the name of theweb3 module
.Todo:
Cute Animal Picture
🦮